fix: balance SV refcount in pp_overload_ft_nv#1
Closed
Conversation
_check() stored the file argument in $_last_call_for for -X _ caching. When the argument was a filehandle reference (not a string path), this prevented the filehandle from being garbage collected, keeping the underlying file descriptor open. This caused "spooky action-at-a-distance" bugs: e.g. a socketpair read hanging because a dup'd write-end filehandle was kept alive by the leaked reference, even after leaving scope. Fix: only cache string filenames in $_last_call_for, not references. Ref: cpan-authors/Test-MockFile#179 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ef-leak fix: prevent filehandle reference leak in stat override
Add CLAUDE.md with project guidance for Claude Code sessions. Exclude CLAUDE.md and local/ directory from Dist::Zilla GatherDir so they don't end up in the CPAN tarball.
Update actions/checkout and CI
_overload_ft_ops_sv() increments the refcount of the returned SV to keep it alive past FREETMPS, but pp_overload_ft_nv never decremented it, leaking one SV per mocked -M/-C/-A call. Add SvREFCNT_dec(status) before each return path in pp_overload_ft_nv. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
We need to close that Pull Request and resubmit it to the parent repo https://github.com/cpanel/Overload-FileCheck |
Owner
|
@Koan-Bot recreate |
Owner
|
@Koan-Bot squash |
Collaborator
Author
|
This fix has already been applied to upstream/main (cpan-authors/Overload-FileCheck). Closing as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add missing
SvREFCNT_dec(status)calls inpp_overload_ft_nvto balance theSvREFCNT_incdone in_overload_ft_ops_sv().Why
_overload_ft_ops_sv()increments the refcount of the returned SV to keep it alive pastFREETMPS, butpp_overload_ft_nv(the only caller) never decremented it — leaking one SV per mocked-M/-C/-Acall.How
Added
SvREFCNT_dec(status)before each of the three return paths inpp_overload_ft_nv: the two fallback-to-real-op paths (when value is -1) and the normal TARG return path.Testing
Full test suite passes (1072 tests, 50 files).